[webkit-reviews] review denied: [Bug 16131] ZWNJ - Display non-printing, invisible character : [Attachment 51108] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 18 16:12:54 PDT 2010
mitz at webkit.org has denied David Yonge-Mallo <davinci at chromium.org>'s request
for review:
Bug 16131: ZWNJ - Display non-printing, invisible character
https://bugs.webkit.org/show_bug.cgi?id=16131
Attachment 51108: Updated patch
https://bugs.webkit.org/attachment.cgi?id=51108&action=review
------- Additional Comments from mitz at webkit.org
> + * platform/graphics/FontFastPath.cpp:
> + (WebCore::Font::canUseGlyphCache): added Arabic presentation forms
Why? And how does it relate to the present bug?
> + // FIXME: A better place for this might be in
GlyphPage::glyphDataForCharacter or
> + // Font::glyphDataForCharacter.
This should be done in GlyphPageTreeNode::initializePage() where LRM, RLM, LRE,
RLE, PDF and other control characters are already handled.
More information about the webkit-reviews
mailing list