[webkit-reviews] review requested: [Bug 36259] <input type=range> does not validate correctly without a renderer and the tests are incorrect : [Attachment 51083] [PATCH] Part 2 - Move Sanitization to HTMLInputElement - Fix Incorrect Tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 13:33:22 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 36259: <input type=range> does not validate correctly without a renderer
and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Attachment 51083: [PATCH] Part 2 - Move Sanitization to HTMLInputElement - Fix
Incorrect Tests
https://bugs.webkit.org/attachment.cgi?id=51083&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
The bulk of the work. The code in the new `clampValue` is copied from
`valueFromElement` but it cannot easily be shared as intermediate values are
used in the `valueFromElement` code. I could create a method with in/out
parameters if desired. These changes end up fixing Bug 16990.


More information about the webkit-reviews mailing list