[webkit-reviews] review granted: [Bug 36177] Multiselect Popup - Listbox click simulation : [Attachment 51034] patch 5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 18 10:19:44 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 36177: Multiselect Popup - Listbox click simulation
https://bugs.webkit.org/show_bug.cgi?id=36177
Attachment 51034: patch 5
https://bugs.webkit.org/attachment.cgi?id=51034&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
> + virtual void listBoxSelectItem(int listIndex, bool
allowMultiplySelections,
> + bool shift, bool fireOnChangeNow = true) = 0;
Please make this one line.
> +void HTMLSelectElement::listBoxSelectItem(int listIndex, bool
allowMultiplySelections,
> + bool shift, bool fireOnChangeNow)
here as well.
>
> + void listBoxSelectItem(int listIndex, bool allowMultiplySelections,
> + bool shift, bool fireOnChangeNow = true);
and here.
Apart from that LGTM.
More information about the webkit-reviews
mailing list