[webkit-reviews] review granted: [Bug 33909] Intro text at Star Wars demo is clipped : [Attachment 51039] Patch4

Thu Mar 18 10:07:00 PDT 2010

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 33909: Intro text at Star Wars demo is clipped
https://bugs.webkit.org/show_bug.cgi?id=33909

Attachment 51039: Patch4
https://bugs.webkit.org/attachment.cgi?id=51039&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: LayoutTests/compositing/repaint/layer-repaint.html
> ===================================================================
> --- LayoutTests/compositing/repaint/layer-repaint.html	(revision 0)
> +++ LayoutTests/compositing/repaint/layer-repaint.html	(revision 0)
> @@ -0,0 +1,40 @@
> +<!DOCTYPE html>
> +
> +<html>
> +<head>
> +  <style type="text/css" media="screen">
> +    .container {
> +	   border: 1px solid black;
> +	   height: 200px;
> +	   width: 200px;
> +	   -webkit-transform: translateZ(0);
> +    }
> +    
> +    #tester {
> +	   margin: 50px;

I think this box needs to not be centered to show the bug, so something like
margin: 10px 50px 90px 50px;

> +	   height: 100px;
> +	   width: 100px;
> +	   background-color: red;
> +    }
> +  </style>
> +  <script type="text/javascript" charset="utf-8">
> +    function doTest() {
> +	   setTimeout("changeBackground();", 500);

We normally try to make tests run as fast as possible; an extra 0.5 secs is
undesirable. It would be good to know if setTimeout( , 0) is enough here.

r=me with those changes to the test.