[webkit-reviews] review granted: [Bug 36102] [Qt] Scaling control API for tiled backing store : [Attachment 51031] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 09:35:11 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 36102: [Qt] Scaling control API for tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=36102

Attachment 51031: patch
https://bugs.webkit.org/attachment.cgi?id=51031&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Please change the QGraphicsWebView::tiledBackingStoreFrozen() to
isTiledBac...Frozen for consistency with Qt API, like isBlocked etc.

Also, those methods would need documentation. Apart from the it looks good to
me.


More information about the webkit-reviews mailing list