[webkit-reviews] review granted: [Bug 36159] Move code related with printing defined in WebFrame.mm to WebCore::PrintContext : [Attachment 50883] refactor-computePageRects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 21:55:55 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 36159: Move code related with printing defined in WebFrame.mm to
WebCore::PrintContext
https://bugs.webkit.org/show_bug.cgi?id=36159

Attachment 50883: refactor-computePageRects
https://bugs.webkit.org/attachment.cgi?id=50883&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
This looks sane. I'll land this patch unless anyone object tomorrow. I want to
wait a moment in case someone have ideas about this.

I asked him to test this manually on Mac by setting scale in the dialog box for
printing and looking the print preview. He said it seems working.


More information about the webkit-reviews mailing list