[webkit-reviews] review denied: [Bug 33520] Mapping from local to container coord space is O(N^2) : [Attachment 50961] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 33520: Mapping from local to container coord space is O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=33520

Attachment 50961: Patch
https://bugs.webkit.org/attachment.cgi?id=50961&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> diff --git a/WebCore/rendering/RenderObject.h
b/WebCore/rendering/RenderObject.h

> -    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject*
/*repaintContainer*/) const { return IntRect(); }
> +    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject*
/*repaintContainer*/, IntPoint* /*cachedOffsetToRepaintContainer*/ = 0) const {
return IntRect(); }

> diff --git a/WebCore/rendering/RenderSVGModelObject.h
b/WebCore/rendering/RenderSVGModelObject.h
> -    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject*
repaintContainer) const;
> +    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject*
repaintContainer, IntSize*) const;

IntPoint or IntSize? The signatures don't match, so something should be broken
here, and isn't getting tested.