[webkit-reviews] review granted: [Bug 36250] Change post-rollout to create-rollout and have it make a new bug instead of posting the rollout to the old bug. : [Attachment 50969] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36250: Change post-rollout to create-rollout and have it make a new bug
instead of posting the rollout to the old bug.
https://bugs.webkit.org/show_bug.cgi?id=36250

Attachment 50969: Patch
https://bugs.webkit.org/attachment.cgi?id=50969&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
period:
 12	    but we might revist this question in the future

You need to explain this better.  "createBug" is the problem step here, no?
295	    # We're not going to post the rollout patch to the old bug.
Instead,
 296	     # we're going to create a new bug that blocks the original bug.
 297	     state["bug_blocked"] = state["bug_id"]
 298	     del state["bug_id"]

This also doesn't help:
 299	     # Now that we've danced around the bug_id issue, we can fill out
the
 300	     # details for the new bug we're going to create.

"danced around?"

(if we don't already have one on file)
We need a FIXME about linking possible bugs here.  We certainly have that
technology (or could build it).

How do you spell "flaky"?  And "dup"?

Otherwise fine.