[webkit-reviews] review requested: [Bug 33477] [V8] V8Index should be generated : [Attachment 50970] Kill it cleaner.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 16:21:02 PDT 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 33477: [V8] V8Index should be generated
https://bugs.webkit.org/show_bug.cgi?id=33477

Attachment 50970: Kill it cleaner.
https://bugs.webkit.org/attachment.cgi?id=50970&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I added to functions to WrapperTypeInfo: a static unwrap function and an
equals() that takes a pointer and compares it to this.	That makes the
comparisons slightly prettier.

Re: Garbage collection, I think I'm properly deleting everything now, but I
feel like there's got to be a more efficient way to do it.  If I'm missing
something obvious, please let me know.


More information about the webkit-reviews mailing list