[webkit-reviews] review requested: [Bug 36167] Spatial Navigation: Add isNull and document convenient methods to FocusCandidate : [Attachment 50940] patch 0.3 - addressed kov's suggestions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 17 12:54:40 PDT 2010
Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked for review:
Bug 36167: Spatial Navigation: Add isNull and document convenient methods to
FocusCandidate
https://bugs.webkit.org/show_bug.cgi?id=36167
Attachment 50940: patch 0.3 - addressed kov's suggestions
https://bugs.webkit.org/attachment.cgi?id=50940&action=review
------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
> I think you should be good repeating the initialization in both constructors,
I
> think that's preferable. Having an additional function seems unnecessary
here.
Done
> Also, I just noticed you're using inline for the small functions. This is
> usually frowned upon unless you have a reason to do it. The compiler should
be
> smart enough to do the optimization otherwise.
Done.
More information about the webkit-reviews
mailing list