[webkit-reviews] review canceled: [Bug 36194] WebGL layout test failures on bots after 33416 : [Attachment 50871] fixed style issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 10:53:00 PDT 2010


Zhenyao Mo <zmo at google.com> has canceled Zhenyao Mo <zmo at google.com>'s request
for review:
Bug 36194: WebGL layout test failures on bots after 33416
https://bugs.webkit.org/show_bug.cgi?id=36194

Attachment 50871: fixed style issue
https://bugs.webkit.org/attachment.cgi?id=50871&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
About the GraphicsContext3D::validateAttributes(), my feeling is that we should
leave PLATFORM(MAC) there.  The reason is that for PLATFORM(CHROMIUM/QT), this
functionality is implemented in GraphicsContex3DInternal::validateAttributes().
 Either use GraphicsContext3D or GraphicsContext3DInternal implementation, but
not both.  The same situation is with all the FBO variables: they are both in
GraphicsContext3D PLATFORM(MAC) and GraphicsContext3DInternal
PLATFORM(CHROMIUM/QT).	Adding the PLATFORM(MAC) is a reminder that those
functions and variables are duplicated and could be combined into one single
implementation.

The vendor quest is moved into the if block as suggested.


More information about the webkit-reviews mailing list