[webkit-reviews] review granted: [Bug 36147] Give keyboard focus to PluginDocuments by default : [Attachment 50839] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 36147: Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

Attachment 50839: Patch
https://bugs.webkit.org/attachment.cgi?id=50839&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/page/EventHandler.cpp
> ===================================================================
> --- WebCore/page/EventHandler.cpp	(revision 56027)
> +++ WebCore/page/EventHandler.cpp	(working copy)
> @@ -2057,6 +2057,8 @@ static Node* eventTargetNodeForDocument(
>      if (!doc)
>	   return 0;
>      Node* node = doc->focusedNode();
> +    if (!node && doc->isPluginDocument())
> +	   node = doc->body()->firstChild();

nit: it might be nice to create a helper function on PluginDocument
that can be used to fetch the embed node.  that way this code here
doesn't need to know the internal DOM structure of the plugin document.

R=me