[webkit-reviews] review requested: [Bug 33477] [V8] V8Index should be generated : [Attachment 50841] Kill V8Index. Kill it dead.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 16 15:00:33 PDT 2010
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 33477: [V8] V8Index should be generated
https://bugs.webkit.org/show_bug.cgi?id=33477
Attachment 50841: Kill V8Index. Kill it dead.
https://bugs.webkit.org/attachment.cgi?id=50841&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
Dromaeo perf for this patch was about a 0.3% improvement on my local box over 3
runs, so I'd say this qualifies as negligible for performance.
antonm: I had to modify the way we store boilerplate wrappers in
V8DOMWindowShell, since this change will remove our monotonically increasing
index. It appears performance is comparable between storing them in a
v8::Array and a wtf/HashMap, but I wanted to call this change to your attention
in case it's a bad idea for some reason that I haven't noticed.
More information about the webkit-reviews
mailing list