[webkit-reviews] review granted: [Bug 36122] Web Inspector: Timeline improvements next iteration : [Attachment 50774] [Patch]: Initial version of patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 36122: Web Inspector: Timeline improvements next iteration
https://bugs.webkit.org/show_bug.cgi?id=36122

Attachment 50774: [Patch]: Initial version of patch.
https://bugs.webkit.org/attachment.cgi?id=50774&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>	   if (sendRequestRecord) { // False if we started instrumentation in
the middle of request.
>	       sendRequestRecord._responseReceivedFormattedTime =
this.startTime;
>	       record.data.url = sendRequestRecord.data.url;
> -	       this.startTime = sendRequestRecord.startTime;
>	       this.details = this._getRecordDetails(sendRequestRecord,
sendRequestRecords);
>	       this.callerScriptName = sendRequestRecord.callerScriptName;
>	       this.callerScriptLine = sendRequestRecord.callerScriptLine;
> @@ -647,7 +703,6 @@ WebInspector.TimelinePanel.FormattedRecord =
function(record, recordStyles, send
>	   var sendRequestRecord = sendRequestRecords[record.data.identifier];
>	   if (sendRequestRecord) {// False for main resource.
>	       record.data.url = sendRequestRecord.data.url;
> -	       this.startTime =
sendRequestRecord._responseReceivedFormattedTime;
>	       this.callerScriptName = sendRequestRecord.callerScriptName;
>	       this.callerScriptLine = sendRequestRecord.callerScriptLine;
>	   }

We could get rid of these as a whole.

> +		      
recordContentTable.appendChild(this._createRow(WebInspector.UIString("Is Main
Resource"), this.data.isMainResource));
> +		   if (typeof this.data.statusCode === "number")

Not sure we need this one.