[webkit-reviews] review requested: [Bug 36122] Web Inspector: Timeline improvements next iteration : [Attachment 50774] [Patch]: Initial version of patch.

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 36122: Web Inspector: Timeline improvements next iteration
https://bugs.webkit.org/show_bug.cgi?id=36122

Attachment 50774: [Patch]: Initial version of patch.
https://bugs.webkit.org/attachment.cgi?id=50774&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
The patch with Timeline improvements
1) Timer Fire events are connecting to Timer Install events;
2) Receive Response and Finish loading events are connecting to Send Request
events;
3) The Receive Response event grab point is moved to ResourceLoader and as
result can have nested events like Parse etc;
4) Top Level events are in collapsed state by default;
5) The events can be glued at any level of event hierarchy;
6) new semitransparent bar was added for connected events. As example if timer
install event got 10 ms and have timeout 100ms then timer install event will
have solid bar for 10ms and semitransparent for 100ms + Timer Fire event
length. The same for Send Request and Receive Response etc;
7) Tests were fixed;
8) Timeline panel will not be cleared at page reload. That will allow us to see
Send Request for main resource and Event(unload);
9) But with zero based Timer timeout was fixed for Timer Install details popup;

10) Some other properties of Send Request event were added to Details popup.