[webkit-reviews] review granted: [Bug 36152] [chromium] Add support for history.pushState and history.replaceState : [Attachment 50758] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 00:12:08 PDT 2010


Adam Barth <abarth at webkit.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 36152: [chromium] Add support for history.pushState and
history.replaceState
https://bugs.webkit.org/show_bug.cgi?id=36152

Attachment 50758: v1 patch
https://bugs.webkit.org/attachment.cgi?id=50758&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  I'm sad about backForwardNavigationScheme, but it looks like that's
already there...

 590	 bool isHashChange =
 591	    
!m_webFrame->frame()->loader()->history()->currentItem()->stateObject();

No need to line break in WebKit-land.


More information about the webkit-reviews mailing list