[webkit-reviews] review granted: [Bug 36155] Let commit-queue land rollout patches even when the tree is red : [Attachment 50762] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36155: Let commit-queue land rollout patches even when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=36155

Attachment 50762: Patch
https://bugs.webkit.org/attachment.cgi?id=50762&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Use a constant:
 101	     return self.name().startswith("ROLLOUT ")

This is no where near 80c:
 154	     valid_patches =
self.committer_validator.patches_after_rejecting_invalid_commiters_and_reviewer
s(all_patches)

You haz made the uglies!
186	    if not patch.is_rollout() and (not self._builders_are_green() or
not self._can_build_and_test() or not self._builders_are_green()):

patch?
 52	"name": "Path1",