[webkit-reviews] review denied: [Bug 36006] Multiselect popups : [Attachment 50683] Rendering

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 36006: Multiselect popups
https://bugs.webkit.org/show_bug.cgi?id=36006

Attachment 50683: Rendering
https://bugs.webkit.org/attachment.cgi?id=50683&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
 
> Adding a compile time flag that when used do:
> 
> * force all <select> elements to use popups.
> * adjust Qt rendering of the new combo elements.
> * provide information to QStyle objects to differentiate beetwing normal
combos and
>   the new multiselect combos.

I guess other platforms might want to use something similar, so maybe it is a
better idea to introduce a generic flag and combine it with PLATFORM(QT) if
needed?

ENABLE_NO_LISTBOXES also doesn't sound very Qt dependent, and from looking at
the code it isn't so I would suggest you refrase yourself a bit in the
ChangeLog.

Also I dislike the name;  Enabling a disabler sounds strange to me :-) or maybe
find a better name. ENABLE(TOUCHABLE_SELECTORS) maybe?