[webkit-reviews] review granted: [Bug 35926] Web Inspector: Hangup when expanding elements with enormous text node content in Elements panel : [Attachment 50403] [PATCH] Bots fixed, explanation added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 15:30:45 PDT 2010


Eric Seidel <eric at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 35926: Web Inspector: Hangup when expanding elements with enormous text
node content in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=35926

Attachment 50403: [PATCH] Bots fixed, explanation added
https://bugs.webkit.org/attachment.cgi?id=50403&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.  However, you should also add a comment next to inRenderedText in
Position.h explaining the runtime of the function, or at least warning that
it's slow.


More information about the webkit-reviews mailing list