[webkit-reviews] review denied: [Bug 35916] [EFL] Add ContextMenuClientEfl.{cpp, h} to WebKit/efl/WebCoreSupport : [Attachment 50299] Add ContextMEnuClientEfl to WK/efl/WebCoreSupport.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 15 15:33:13 PDT 2010
Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35916: [EFL] Add ContextMenuClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=35916
Attachment 50299: Add ContextMEnuClientEfl to WK/efl/WebCoreSupport.
https://bugs.webkit.org/attachment.cgi?id=50299&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Style error:
56 Evas_Object *m_view;
WebCore:: is not needed in a bunch of these:
+ virtual void searchWithGoogle(const WebCore::Frame*);
All these copyrights in the .h file aren't needed:
+/*
+ * Copyright (C) 2006 Zack Rusin <zack at kde.org>
+ * Copyright (C) 2008 INdT - Instituto Nokia de Tecnologia
+ * Copyright (C) 2009-2010 ProFUSION embedded systems
+ * Copyright (C) 2009-2010 Samsung Electronics
More information about the webkit-reviews
mailing list