[webkit-reviews] review requested: [Bug 36128] [Gtk] nameFromChildren is obsolete : [Attachment 50725] proposed fix - no test (yet)

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 36128: [Gtk] nameFromChildren is obsolete
https://bugs.webkit.org/show_bug.cgi?id=36128

Attachment 50725: proposed fix - no test (yet)
https://bugs.webkit.org/attachment.cgi?id=50725&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This patch fixes the problem and causes labels (and cell headers) to once again
correctly report their name/description.

I will attach the test separately. The reason being that something* is
preventing accessible text from being exposed with layout tests (or something
that I'm doing in my layout test).

*I'm still digging, but the difference seems to be in TextIterator.cpp:
plainTextToMallocAllocatedBuffer works as expected during actual use (i.e. by a
user of AT accessing content). With my layout test, it returns NULL. :-(