[webkit-reviews] review granted: [Bug 36020] Spatial Navigation: Add a scrollIntoView call when focusing an element. : [Attachment 50711] patch 0.3 - same as 0.2 + adds a better ChangeLog entry

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36020: Spatial Navigation: Add a scrollIntoView call when focusing an
element.
https://bugs.webkit.org/show_bug.cgi?id=36020

Attachment 50711: patch 0.3 - same as 0.2 + adds a better ChangeLog entry
https://bugs.webkit.org/attachment.cgi?id=50711&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> +void scrollIntoView(Element* element)
> +{
> +    // NOTE: Element's scrollIntoView method could had been used here, but
> +    // it is preferable to inflate |element|'s bounding rect a bit before
> +    // scrolling it for accurate reason.
> +    // Element's scrollIntoView method does not provide this flexibility.
> +    static const int fudgeFactor = 2;

Shouldn't this be related to the platform's focus outline width? That
information doesn't seem to be available, though.

r=me