[webkit-reviews] review granted: [Bug 36108] option-pageup/down should move cursor on chromium mac : [Attachment 50697] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 36108: option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108

Attachment 50697: Patch
https://bugs.webkit.org/attachment.cgi?id=50697&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if !OS(DARWIN)
>      { VKEY_PRIOR,  0,		  "MovePageUp"			       
 },
>      { VKEY_NEXT,   0,		  "MovePageDown"		       
 },
> +#endif

Long term this is not the right way to conditional user-interface differences
between platforms. But I suppose Chromium does this consistently for
Mac-specific user interface choices, and cleaning that up can wait for the
changes Maciej proposed to clean up the platform conditionals to be deployed.
And I care more about the way this is done in shared code than in
Chromium-specific code.

r=me