[webkit-reviews] review denied: [Bug 35333] [GTK] video playback position query flood when mouse over the video element : [Attachment 50698] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 15 07:36:17 PDT 2010
Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 35333: [GTK] video playback position query flood when mouse over the video
element
https://bugs.webkit.org/show_bug.cgi?id=35333
Attachment 50698: updated patch
https://bugs.webkit.org/attachment.cgi?id=50698&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
You're still adding too much to one single change. You're changing three
separate things that are easily separatable: the decision on how to paint the
button, the changes to media duration query, and the filtering of the messages.
I understand they are all part of fixing this bug, but this does not mean they
should go in at the same time. Having all of them in at the same time will make
this commit semi-unuseful for bisecting. What caused a problem with the
play/pause behavior changing, if it does? If we find this commit to be the
problem, we'll have to manually check which of the three changes is
responsible. So, I'm OK with all three changes, but let's split them, and then
we'll get them in, yeah =).
More information about the webkit-reviews
mailing list