[webkit-reviews] review granted: [Bug 33413] selection.modify extends too far with 'lineboundary' : [Attachment 50687] clenaup comment, update windows result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 00:11:40 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 33413: selection.modify extends too far with 'lineboundary'
https://bugs.webkit.org/show_bug.cgi?id=33413

Attachment 50687: clenaup comment, update windows result
https://bugs.webkit.org/attachment.cgi?id=50687&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	       // LineBoundary granularity emulates
> +	       // [NSTextView moveToRightEndOfLineAndModifySelection:].

You didn't fully address my comments here - it's better to talk about
user-visible behavior than about low level methods, and the dash sign is an
integral part of method name. I still think we'd be better without any comment.


r=me


More information about the webkit-reviews mailing list