[webkit-reviews] review granted: [Bug 36095] REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set : [Attachment 50679] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 36095: REGRESSION(r53287): drop event is not fired if
dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095

Attachment 50679: Patch
https://bugs.webkit.org/attachment.cgi?id=50679&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    , m_dropEffect("none")
> +    , m_dropEffect("uninitialized")

Why not use the null string instead of "uninitialized"?

Both initializing to null and checking for null are more efficient than
initializing to "uninitialized" and comparing with "uninitialized". Also, I
think null is a pretty clear way to represent a drop effect that has not been
explicitly set; arguably clearer than the string "uninitialized".

> +static DragOperation defaultOperationForDrag(const DragOperation& srcOpMask)


Since DragOperation is a scalar, I think typing it just DragOperation is fine;
it doesn't have to be const DragOperation&.

r=me