[webkit-reviews] review granted: [Bug 36092] noscript tag should render when @sandbox disables JavaScript : [Attachment 50664] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36092: noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Attachment 50664: Patch
https://bugs.webkit.org/attachment.cgi?id=50664&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It's great that you found all six call sites and fixed them. But the test
checks only one or two of them. It would be better to make tests that cover as
many of these as possible.

It might be good to have a comment in the Settings.h header file warning people
away from using the isJavaScriptEnabled function to decide whether JavaScript
is enabled. It's almost always wrong to use that function unless the code is
simply trying to tweak settings. We don't want to make that header too
confusing, but we also don't want anyone adding any new call sites like these.

r=me despite the limited test coverage