[webkit-reviews] review requested: [Bug 17113] "event.ctrlKey" is always false when dragging an element with "ctrl" key down : [Attachment 50665] Use the new PlatformKeyboardEvent::getCurrentModifierState() to add the information about which modifier keys are pressed to the drag event

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has asked  for review:
Bug 17113: "event.ctrlKey" is always false when dragging an element with "ctrl"
key down
https://bugs.webkit.org/show_bug.cgi?id=17113

Attachment 50665: Use the new PlatformKeyboardEvent::getCurrentModifierState()
to add the information about which modifier keys are pressed to the drag event
https://bugs.webkit.org/attachment.cgi?id=50665&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
As in the last patch, I did not add in tests here (hence the No new tests
(OOPS!) in the ChangeLog) because of a bug with DumpRenderTree, similar to the
bug https://bugs.webkit.org/show_bug.cgi?id=36085 . At least on the Mac, the
mechanism used to implement getCurrentModifierState (GetCurrentKeyModifiers())
does not appear to get modified by the eventSender.mouseDown method.

Should I include that failing test in this fix and just add it to the skip list
for now? Any ideas on what might be used to make GetCurrentKeyModifiers (which
appears to be a Carbon method) use the information from the
eventSender.mouseDown method?

The other option would be a manual test, but I talked earlier to Krit, and he
strongly suggested against that (for the good reason that manual tests are less
likely to get run).