[webkit-reviews] review requested: [Bug 17113] "event.ctrlKey" is always false when dragging an element with "ctrl" key down : [Attachment 50662] Implement returning the correct state of the modifier keys being pressed or not during a drag for Mac, Chromium, Haiku, and Windows platforms.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 13 13:18:12 PST 2010


Jessie Berlin <jberlin at webkit.org> has asked  for review:
Bug 17113: "event.ctrlKey" is always false when dragging an element with "ctrl"
key down
https://bugs.webkit.org/show_bug.cgi?id=17113

Attachment 50662: Implement returning the correct state of the modifier keys
being pressed or not during a drag for Mac, Chromium, Haiku, and Windows
platforms.
https://bugs.webkit.org/attachment.cgi?id=50662&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
Tested on Mac OS X 10.6

As noted in the ChangeLog, did not add in tests here because of a bug with
DumpRenderTree:

 I have written a test for the Mac platform that is not included in this patch
and depends on https://bugs.webkit.org/show_bug.cgi?id=36085 (DumpRenderTree
eventSender.mouseDown should change NSApp currentEvent return value) being
fixed. Should I include it in this fix and just add it to the skip list until
that bug is fixed?

Also, should I split off this bug into multiple smaller bugs, one per each
platform which I did not provide an implementation? (Qt, GTK, EFL, WX)


More information about the webkit-reviews mailing list