[webkit-reviews] review denied: [Bug 34741] MathML Support for mfrac : [Attachment 49951] Updated the patch to the latest trunk and added other changes suggested

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Alex Milowski
<alex at milowski.com>'s request for review:
Bug 34741: MathML Support for mfrac
https://bugs.webkit.org/show_bug.cgi?id=34741

Attachment 49951: Updated the patch to the latest trunk and added other changes
suggested 
https://bugs.webkit.org/attachment.cgi?id=49951&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    if (lastChild())
> +	   if (lastChild()->isRenderBlock()) {
> +	       RenderBlock* denominator = toRenderBlock(lastChild());
> +	       int previousWidth = denominator->style()->borderTopWidth();
> +	       int borderWidth = static_cast<int>(ceil(gFractionBarWidth *
style()->fontSize()));
> +	       denominator->style()->setBorderTopWidth(previousWidth *
borderWidth);
> +	   }
> +    
> +    if (previousSibling())
> +	   if (previousSibling()->isRenderBlock()) {
> +	       RenderBlock* sibling = toRenderBlock(previousSibling());
> +	       verticalAlignCompute(sibling);
> +	       RenderBlock::layout();
> +	       return;
> +	   }
> +    if (nextSibling())
> +	   if (nextSibling()->isRenderBlock()) {
> +	       RenderBlock* sibling = toRenderBlock(nextSibling());
> +	       verticalAlignCompute(sibling);
> +	   }
> +    

The above is against our coding style. An if with contents (comments included)
spanding more than one line should use {}