[webkit-reviews] review requested: [Bug 19012] [Gtk][Qt] Temporary files passed to NPAPI plugins are deleted immediately : [Attachment 50655] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 13 06:14:49 PST 2010


arno. <arno at renevier.net> has asked  for review:
Bug 19012: [Gtk][Qt] Temporary files passed to NPAPI plugins are deleted
immediately
https://bugs.webkit.org/show_bug.cgi?id=19012

Attachment 50655: patch v1
https://bugs.webkit.org/attachment.cgi?id=50655&action=review

------- Additional Comments from arno. <arno at renevier.net>
I don't know about qt, but for gtk, but is still not fixed.

I tried to improve upon marcoil's patch but by calling destroyStream multiple
times, I always ended up with segfaults or failing patches. Then, I thought
about deleting temporary file in PluginStream destructor. That seems to work.


More information about the webkit-reviews mailing list