[webkit-reviews] review granted: [Bug 31533] webkitpy __init__.py (webkit-patch) should detect python < 2.5 and show a nice error message : [Attachment 50180] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 31533: webkitpy __init__.py (webkit-patch) should detect python < 2.5 and
show a nice error message
https://bugs.webkit.org/show_bug.cgi?id=31533

Attachment 50180: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=50180&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not wild about the name "patcher.py".

We've discussed the issue of python version requirements a bunch.  I'm not 100%
sure what the final resolution was, but this patch is just making the code
print a nicer error message.  If we want to support older versions of Python,
we can still do that.