[webkit-reviews] review granted: [Bug 35828] python: Remove non-trivial code from webkitpy/__init__.py : [Attachment 50151] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 13 02:08:22 PST 2010
Adam Barth <abarth at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35828: python: Remove non-trivial code from webkitpy/__init__.py
https://bugs.webkit.org/show_bug.cgi?id=35828
Attachment 50151: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=50151&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. I'm slightly sad that we don't say "mechanize" anywhere when we import
Browser. Is there some way to say:
from webkitpy.thirdparty.autoinstalled.mechanize import Browser
That seems the most natural to me.
(In any case, this patch is an improvement.)
More information about the webkit-reviews
mailing list