[webkit-reviews] review granted: [Bug 34942] Fullscreen API naming is inconsistent : [Attachment 50643] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 34942: Fullscreen API naming is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=34942

Attachment 50643: Patch
https://bugs.webkit.org/attachment.cgi?id=50643&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/html/HTMLVideoElement.idl
> ===================================================================
> --- WebCore/html/HTMLVideoElement.idl (revision 55928)
> +++ WebCore/html/HTMLVideoElement.idl (working copy)
> @@ -33,6 +33,10 @@ module html {
>  
>	   readonly attribute boolean webkitSupportsFullscreen;
>	   readonly attribute boolean webkitDisplayingFullscreen;
> +
> +	   [NeedsUserGestureCheck] void webkitEnterFullscreen()
> +	       raises (DOMException);
> +	   void webkitExitFullscreen();
>      
>	   [NeedsUserGestureCheck] void webkitEnterFullScreen()
>	       raises (DOMException);

I think you file a bugzilla to remove the old versions, and add a comment
referencing it.

> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 55944)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,31 @@
> +2010-03-12  Beth Dakin  <bdakin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen 
> +	   API naming is inconsistent
> +	   -and corresponding-
> +	   <rdar://problem/7729165>
> +
> +	   This patch changes all occurrences of "fullScreen" to the more 
> +	   popular "fullscreen."
> +
> +	   * Plugins/Hosted/NetscapePluginHostProxy.h:
> +	   (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
> +	   * Plugins/Hosted/NetscapePluginHostProxy.mm:
> +	   (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
> +	   (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
> +	   (WebKit::NetscapePluginHostProxy::didExitFullscreen):
> +	   (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
> +	   (WKPCSetFullscreenWindowIsShowing):
> +	   * Plugins/Hosted/WebKitPluginClient.defs:
> +	   * Plugins/WebNetscapePluginView.mm:
> +	   (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
> +	   (-[WebNetscapePluginView _createPlugin]):
> +	   (-[WebNetscapePluginView _destroyPlugin]):
> +	   * WebView/WebVideoFullscreenHUDWindowController.mm:
> +	   (-[WebVideoFullscreenHUDWindowController windowDidLoad]):

I think it's fine if you don't change the plugin-related code in this patch; up
to you.

r=me