[webkit-reviews] review granted: [Bug 33739] Fullscreen video HUD stays on top when switching to another window (e.g. via Alt-Tab) : [Attachment 50556] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 33739: Fullscreen video HUD stays on top when switching to another window
(e.g. via Alt-Tab)
https://bugs.webkit.org/show_bug.cgi?id=33739

Attachment 50556: Patch
https://bugs.webkit.org/attachment.cgi?id=50556&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void FullscreenVideoController::draw()
>  {
> +    HWND foregroundWindow = GetForegroundWindow();
> +    if (foregroundWindow == m_videoWindow)
> +	   createHUDWindow();
> +    else if (foregroundWindow != m_hudWindow)
> +	   destroyHUDWindow();
> +

After this, I think you should assert that m_hudWindow is non-null. And maybe
you should bail if it is null, in release builds.

r=me