[webkit-reviews] review granted: [Bug 35936] [EFL] Add ewk_view_single.c to WK/efl/ewk : [Attachment 50336] Add ewk_view_single to WK/efl/ewk

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35936: [EFL] Add ewk_view_single.c to WK/efl/ewk
https://bugs.webkit.org/show_bug.cgi?id=35936

Attachment 50336: Add ewk_view_single to WK/efl/ewk
https://bugs.webkit.org/attachment.cgi?id=50336&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
The coding style differs from that of WebKit, but in the WebKit/eft you can use
the EFL C style if that is what you'ld like.

Personally I think you could benefit from more descriptive variable names than
oh (height?) etc.

I see that you implement some kind of tiling. It would be nice to use the new
tiling system in WebCore if possible. Doing that you will be able to use the
upcoming 'paint in another thread' patch.