[webkit-reviews] review denied: [Bug 36011] Add TextEncoding::usesBackslashAsCurrencySymbol() : [Attachment 50488] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 12 09:17:06 PST 2010
Darin Adler <darin at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 36011: Add TextEncoding::usesBackslashAsCurrencySymbol()
https://bugs.webkit.org/show_bug.cgi?id=36011
Attachment 50488: Patch v1
https://bugs.webkit.org/attachment.cgi?id=50488&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
The logic here is backwards. This changes some "==" to "!=".
As a side note, I also personally don’t think this refactoring is an
improvement. The old code seems clearer to me.
More information about the webkit-reviews
mailing list