[webkit-reviews] review denied: [Bug 35589] Change the way of prefetching DNS to allow prefetching function to use full URL : [Attachment 50412] ResourceHandle::prepareForURL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 12 08:54:32 PST 2010


Adam Barth <abarth at webkit.org> has denied José Millán Soto
<jmillan at igalia.com>'s request for review:
Bug 35589: Change the way of prefetching DNS to allow prefetching function to
use full URL
https://bugs.webkit.org/show_bug.cgi?id=35589

Attachment 50412: ResourceHandle::prepareForURL
https://bugs.webkit.org/attachment.cgi?id=50412&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please fix the style nits.

+ KURL url(ParsedURLString, "http://"+hostname);

Are you sure you want to do this?  prefetchDNS is pretty performance sensitive.


More information about the webkit-reviews mailing list