[webkit-reviews] review granted: [Bug 35949] Hover states not updated when overflow section scrolls under stationary mouse pointer : [Attachment 50576] Dispatch a fake mouse move event shrotly after scrolling

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 35949: Hover states not updated when overflow section scrolls under
stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949

Attachment 50576: Dispatch a fake mouse move event shrotly after scrolling
https://bugs.webkit.org/attachment.cgi?id=50576&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +void EventHandler::cancelFakeMouseMoveEvent()
> +{
> +    if (!m_fakeMouseMoveEventTimer.isActive())
> +	   return;
> +
> +    m_fakeMouseMoveEventTimer.stop();
> +}

I don't think you need to check isActive before calling stop. It's safe to call
it even if the timer is not active.

> +void EventHandler::fakeMouseMoveEventTimerFired(Timer<EventHandler>* timer)
> +{
> +    ASSERT_ARG(timer, timer == &m_fakeMouseMoveEventTimer);

You need to use ASSERT_UNUSED here because "timer" is otherwise unused in this
function. I think this is why the Mac EWS build indicates a failure.

I'm a little sad that the test requires a timeout and can't run
instantaneously. Could it instead be based on the timing of the first mouse
move event?

r=me, but please fix the Mac build issue