[webkit-reviews] review granted: [Bug 36049] PrintContext.end() not called from PrintContext::pageNumberForElement() : [Attachment 50578] Always call PrintContext.end() from PrintContext::pageNumberForElement().
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 11 23:51:35 PST 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 36049: PrintContext.end() not called from
PrintContext::pageNumberForElement()
https://bugs.webkit.org/show_bug.cgi?id=36049
Attachment 50578: Always call PrintContext.end() from
PrintContext::pageNumberForElement().
https://bugs.webkit.org/attachment.cgi?id=50578&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the nice catch!
> + Always call PrintContext.end() from
PrintContext::pageNumberForElement().
> + https://bugs.webkit.org/show_bug.cgi?id=36049
> +
We usually write why we don't need new tests.
More information about the webkit-reviews
mailing list