[webkit-reviews] review requested: [Bug 35937] Support for HTMLProgressElement : [Attachment 50575] Patch v8

[bugzilla-daemon at webkit.org]

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 35937: Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937

Attachment 50575: Patch v8
https://bugs.webkit.org/attachment.cgi?id=50575&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
This patch is addressing comment #20.

(In reply to comment #20)
> Should this instead inherit from RenderReplaced? What other render class were

> you basing this one on?

I was asking myself the same question. I chose RenderBlock after reading
dHyatt's blog at 
<http://webkit.org/blog/115/webcore-rendering-ii-blocks-and-inlines/>

"Form controls are actually a strange special case. They are still replaced
elements, but because they are implemented by the engine, controls actually
ultimately subclass from RenderBlock."