[webkit-reviews] review granted: [Bug 36038] Add more test cases for Blob.slice : [Attachment 50554] Proposed Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 36038: Add more test cases for Blob.slice
https://bugs.webkit.org/show_bug.cgi?id=36038

Attachment 50554: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=50554&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
r=me with a nit:

> diff --git
a/LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js
b/LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js

>  function runTest()
> +
> +    debug("Test slicing and sending a small file.");
> +    dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 2, 4);

> +    dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 2,
20);
> +    dragAndSliceStableFile("resources/file-for-drag-to-send.txt", 10, 15,
20);
> +
> +    debug("Test slicing and sending a big file.");
> +    dragAndSliceStableFile("resources/abe.png", 12242, 10, 40);
> +    dragAndSliceStableFile("resources/abe.png", 12242, 10, 3000);
> +    dragAndSliceStableFile("resources/abe.png", 12242, 3000, 15000);

It would be nice to add info on why this file size is enough... Also, enough
for what? I think you are trying to hit the codepath where some buffer is
getting full, it's good to mention it.