[webkit-reviews] review denied: [Bug 36026] [v8] Add V8 bindings for DOMFormData : [Attachment 50528] Fix style error

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 36026: [v8] Add V8 bindings for DOMFormData
https://bugs.webkit.org/show_bug.cgi?id=36026

Attachment 50528: Fix style error
https://bugs.webkit.org/attachment.cgi?id=50528&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Looks good in general.	However, I don't see DOMFormData.idl anywhere.	I
assume that's why the EWS failed to build?

A couple additional minor things:

> diff --git a/WebCore/bindings/v8/DOMObjectsInclude.h
b/WebCore/bindings/v8/DOMObjectsInclude.h
> index cd8443a..fd1a875 100644
> --- a/WebCore/bindings/v8/DOMObjectsInclude.h
> +++ b/WebCore/bindings/v8/DOMObjectsInclude.h
> @@ -82,6 +82,7 @@
>  #include "DocumentType.h"
>  #include "DocumentFragment.h"
>  #include "DOMCoreException.h"
> +#include "DOMFormData.h"
>  #include "DOMImplementation.h"
>  #include "DOMParser.h"
>  #include "DOMSelection.h"

I deleted this file today, since it wasn't getting much use.  Feel free to
revert this part of the change.

> diff --git a/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
b/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> index b626499..76ad172 100644
> --- a/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> +++ b/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> @@ -94,6 +94,7 @@
>  #include "bindings/V8DocumentFragment.cpp"
>  #include "bindings/V8DocumentType.cpp"
>  #include "bindings/V8DOMCoreException.cpp"
> +#include "bindings/V8DOMFormData.cpp"
>  #include "bindings/V8DOMImplementation.cpp"
>  #include "bindings/V8DOMParser.cpp"
>  #include "bindings/V8DOMSelection.cpp"

This file is current unused and about to be deleted as well.