[webkit-reviews] review granted: [Bug 36027] Content of 3D tests appears in the bottom right corner sometimes : [Attachment 50545] Patch2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 36027: Content of 3D tests appears in the bottom right corner sometimes
https://bugs.webkit.org/show_bug.cgi?id=36027

Attachment 50545: Patch2
https://bugs.webkit.org/attachment.cgi?id=50545&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/manual-tests/win/horizontal-scroll-composited.html
> ===================================================================
> --- WebCore/manual-tests/win/horizontal-scroll-composited.html       
(revision 55850)
> +++ WebCore/manual-tests/win/horizontal-scroll-composited.html       
(working copy)
> @@ -5,4 +5,4 @@
>  <br />
>  Try scolling right and left and verify that the content is displayed
correctly. 
>  </div>
> -<div style="-webkit-transform: translatez(0); width: 1000px; height: 800px;
border-style: solid; border-color: Red; border-width: 3px; background-image:
url(../resources/apple.jpg); background-repeat:repeat"></div>
> +<div style="-webkit-transform: rotate3d(0,0,1,0deg); width: 1000px; height:
800px; border-style: solid; border-color: Red; border-width: 3px;
background-image: url(../resources/apple.jpg); background-repeat:repeat"></div>


Is this change really needed?
> 
> Property changes on:
WebCore/manual-tests/win/horizontal-scroll-composited.html
> ___________________________________________________________________
> Added: svn:executable

That's bad.

> Index: WebCore/manual-tests/win/launch-milliondollar.html
> Index: WebCore/manual-tests/win/vertical-scroll-composited.html

I'd like to see these be non-manual tests, so that when we one day have pixel
testing on Windows, they'll be useful. They'd go in
LayoutTests/compositing/geometry.

> Index: WebCore/platform/graphics/win/WKCACFLayerRenderer.h
> ===================================================================
> --- WebCore/platform/graphics/win/WKCACFLayerRenderer.h	(revision
55850)
> +++ WebCore/platform/graphics/win/WKCACFLayerRenderer.h	(working copy)
> @@ -60,16 +60,17 @@ public:
>      static bool acceleratedCompositingAvailable();
>      static void didFlushContext(CACFContextRef);
>  
> -    void setScrollFrame(const IntRect&);
> +    void setScrollFrame(const IntPoint&, const int, const int);

Use a const IntSize& for height and width.

> +    int m_scrollFrameWidth;
> +    int m_scrollFrameHeight;

Use IntSize here.

r=me with the code changes, and I'd prefer that you made some LayoutTests.