[webkit-reviews] review denied: [Bug 35288] [Haiku] Implement ImageBuffer support : [Attachment 49273] Patch implementing StillImage class

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 35288: [Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288

Attachment 49273: Patch implementing StillImage class
https://bugs.webkit.org/attachment.cgi?id=49273&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just some minor things to address.

> Index: WebCore/platform/graphics/haiku/StillImageHaiku.cpp
> +unsigned StillImage::decodedSize() const
> +{
> +    // TODO: It could be wise to return 0 here, since we don't want WebCore

Use FIXME instead of TODO.



> Index: WebCore/platform/graphics/haiku/StillImageHaiku.h

> +    virtual void destroyDecodedData(bool = true);

You should put in the parameter name here. I had no idea what the bool for was.



> +    StillImage(const BBitmap& bitmap);

You should remove the param name "bitmap" here. as it adds no information.