[webkit-reviews] review granted: [Bug 32047] Make appcache layouttests top-frame-*.html more robust for async checking event : [Attachment 50542] Patch.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 32047: Make appcache layouttests top-frame-*.html more robust for async
checking event
https://bugs.webkit.org/show_bug.cgi?id=32047

Attachment 50542: Patch.
https://bugs.webkit.org/attachment.cgi?id=50542&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
>	  Also added check for "noupdate" event.

I'm not sure if I understand this change. What you are doing here is replacing
a handler that calls test() with one that logs and checks whether the test is
done. The counter doesn't match the number of events received, because the
original handler doesn't increment it.

applicationCache.onnoupdate = function() { test() }
applicationCache.oncached = function() { test() }

Do the tests still pass in browser both on first try (with empty appcache), and
on reload?

r=me though.