[webkit-reviews] review denied: [Bug 34653] Charset parameter set by setRequestHeader as "KOI8-R" is NOT changed to UTF-8 : [Attachment 50538] fix patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 11 14:40:45 PST 2010
Alexey Proskuryakov <ap at webkit.org> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 34653: Charset parameter set by setRequestHeader as "KOI8-R" is NOT changed
to UTF-8
https://bugs.webkit.org/show_bug.cgi?id=34653
Attachment 50538: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=50538&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+ m_requestHeaders.remove("Content-Type");
+ m_requestHeaders.set("Content-Type", contentType);
Is there actually necessary to remove before setting?
+ req.open("POST", "print-content-type.cgi", false);
This can't work - the cgi script is in resources/ subdirectory. Please fix and
make the test resilient against such errors.
This can't go in without an answer to my question about other browsers'
behavior.
More information about the webkit-reviews
mailing list