[webkit-reviews] review granted: [Bug 36024] Add DOMFormData.idl to expose FormData interface : [Attachment 50521] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 13:28:12 PST 2010


Sam Weinig <sam at webkit.org> has granted Jian Li <jianli at chromium.org>'s request
for review:
Bug 36024: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Attachment 50521: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=50521&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +
> +JSValue JSDOMFormData::append(ExecState* exec, const ArgList& args)
> +{
> +    if (args.size() < 2)
> +	   return throwError(exec, SyntaxError, "Not enough arguments");

We don't generally throw on too few arguments, but rather let the undefined
value get toStringed.

Otherwise, this looks good. r=me if you make that change.


More information about the webkit-reviews mailing list