[webkit-reviews] review denied: [Bug 35992] Crash at MediaPlayer::duration() : [Attachment 50529] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 35992: Crash at MediaPlayer::duration()
https://bugs.webkit.org/show_bug.cgi?id=35992

Attachment 50529: Patch
https://bugs.webkit.org/attachment.cgi?id=50529&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
 22	function duration()
 23	{
 24	    var d = video.duration;
 25	    if (count++ >= 10 && window.layoutTestController)
 26		layoutTestController.notifyDone();
 27	}

I should have noticed this the first time around, but what is magic about 10,
what makes you certain that this will work on both fast and slow machines? Can
you trigger the crash by getting the duration from an onload handler in the
child document (or from a function called via settimout() called from an onload
handler)?