[webkit-reviews] review denied: [Bug 24943] Command-B and Command-I do not generate keydown events in contentEditable regions. : [Attachment 50473] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 24943: Command-B and Command-I do not generate keydown events in
contentEditable regions.
https://bugs.webkit.org/show_bug.cgi?id=24943

Attachment 50473: Patch
https://bugs.webkit.org/attachment.cgi?id=50473&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks so much for tackling this.

> +	   No test because eventSender.keyDown sends key events directly to
> +	   webcore so we can't test key handling in WebKit/mac.

That is not true. EventSendingController sends a keyDown like this:

    [[[[mainFrame webView] window] firstResponder] keyDown:event];

Did you try making a test? What happened?

Maybe the real issue is that DumpRenderTree doesn't call performKeyEquivalent.
We could easily fix DumpRenderTree so it does.